Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key_vault_secret: Set value of recoverd key vault secret #10920

Merged
merged 1 commit into from
Mar 11, 2021
Merged

key_vault_secret: Set value of recoverd key vault secret #10920

merged 1 commit into from
Mar 11, 2021

Conversation

dvob
Copy link
Contributor

@dvob dvob commented Mar 10, 2021

Currently if you create a secret for which already a soft-deleted secret exists the soft-deleted secret is only recoverd but the value is not set. This change also sets the value after the secret is recovered.

Currently if you create a secret for which already a soft-deleted
secret exists the soft-deleted secret is only recoverd but the value
is not set. This change sets the value after the recovery.
@ghost ghost added the size/XS label Mar 10, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @dvob 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-03-11 at 11 48 28

@tombuildsstuff tombuildsstuff merged commit 1c277bc into hashicorp:master Mar 11, 2021
tombuildsstuff added a commit that referenced this pull request Mar 11, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants