Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource azurerm_healthbot #11002

Merged
merged 11 commits into from
Apr 23, 2021
Merged

New Resource azurerm_healthbot #11002

merged 11 commits into from
Apr 23, 2021

Conversation

haiyuazhang
Copy link
Contributor

@haiyuazhang haiyuazhang commented Mar 17, 2021

Support for Azure health bot Service

The ACC Test PASS log:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/bot -run=TestAccBotHealthbot* -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
2021/04/21 14:03:44 [DEBUG] not using binary driver name, it's no longer needed
2021/04/21 14:03:46 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccBotHealthbot_basic
=== PAUSE TestAccBotHealthbot_basic
=== RUN   TestAccBotHealthbot_requiresImport
=== PAUSE TestAccBotHealthbot_requiresImport
=== RUN   TestAccBotHealthbot_complete
=== PAUSE TestAccBotHealthbot_complete
=== RUN   TestAccBotHealthbot_update
=== PAUSE TestAccBotHealthbot_update
=== CONT  TestAccBotHealthbot_basic
=== CONT  TestAccBotHealthbot_update
=== CONT  TestAccBotHealthbot_complete
=== CONT  TestAccBotHealthbot_requiresImport
--- PASS: TestAccBotHealthbot_complete (202.30s)
--- PASS: TestAccBotHealthbot_basic (205.21s)
--- PASS: TestAccBotHealthbot_requiresImport (216.32s)
--- PASS: TestAccBotHealthbot_update (331.44s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/bot 332.966s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haiyuazhang 0 overall this looks good btu i've left some questions inline to address

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @haiyuazhang - i think azurerm_bot_healthbot is a bit redundant as it has bot in it twice, if we change this to azurerm_healthbot i think this will be good to merge!

@haiyuazhang
Copy link
Contributor Author

@katbyte
I've rename the resource to azurerm_healthbot. Besides, I've rebased the code from master branch to fix the deps check error caused by the sdk version upgrade in master branch. Thanks for your comments and review.

@ghost ghost removed the waiting-response label Apr 21, 2021
@katbyte katbyte added this to the v2.57.0 milestone Apr 22, 2021
@haiyuazhang haiyuazhang changed the title New Resource azurerm_healthbot_service New Resource azurerm_healthbot Apr 22, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haiyuazhang - aside from one comment about a property name this looks good - once that is changed this should be good to merge!

website/docs/r/bot_healthbot.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/bot/bot_healthbot_resource.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haiyuazhang - aside from one comment about a property name this looks good - once that is changed this should be good to merge!

@katbyte katbyte merged commit 9507698 into hashicorp:master Apr 23, 2021
katbyte added a commit that referenced this pull request Apr 23, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants