Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_azure_file_storage: Add support for key_vault_password #11436

Merged
merged 1 commit into from
Apr 22, 2021
Merged

azurerm_data_factory_linked_service_azure_file_storage: Add support for key_vault_password #11436

merged 1 commit into from
Apr 22, 2021

Conversation

favoretti
Copy link
Collaborator

Fixes #11408

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -run=TestAccDataFactoryLinkedServiceAzureFileStorage_KeyVaultReference -timeout=1000m
2021/04/22 13:22:03 [DEBUG] not using binary driver name, it's no longer needed
2021/04/22 13:22:03 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataFactoryLinkedServiceAzureFileStorage_KeyVaultReference
=== PAUSE TestAccDataFactoryLinkedServiceAzureFileStorage_KeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureFileStorage_KeyVaultReference
--- PASS: TestAccDataFactoryLinkedServiceAzureFileStorage_KeyVaultReference (335.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	337.385s

@favoretti
Copy link
Collaborator Author

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti - LGTM 👍

@katbyte katbyte merged commit e29d202 into hashicorp:master Apr 22, 2021
katbyte added a commit that referenced this pull request Apr 22, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for retrieving Storage Account Key from KV in Data Factory File Storage Linked Service
2 participants