Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_iot_time_series_insights_event_source_iothub #11533

Merged
merged 3 commits into from
Apr 30, 2021
Merged

New Resource: azurerm_iot_time_series_insights_event_source_iothub #11533

merged 3 commits into from
Apr 30, 2021

Conversation

mbfrahry
Copy link
Member 

--- PASS: TestAccIoTTimeSeriesInsightsEventSourceIoTHub_basic (394.99s)
--- PASS: TestAccIoTTimeSeriesInsightsEventSourceIoTHub_update (504.49s)

@mbfrahry mbfrahry requested a review from a team April 29, 2021 23:38
katbyte
katbyte approved these changes Apr 30, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry - aside from a couple comments LGTM 👍

azurerm/internal/services/iottimeseriesinsights/iot_time_series_insights_event_source_iothub.go Outdated
ValidateFunc: validation.StringIsNotEmpty,
},

"key_name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

Suggested change
"key_name": {
"shared_access_key_name": {

website/docs/r/iot_time_series_insights_event_source_iothub.html.markdown Outdated

* `event_source_resource_id` - (Required) Specifies the resource id where events will be coming from.

* `key_name` - (Required) Specifies the name of the Shared Access Policy key that grants the Time Series Insights service access to the IotHub.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong description?

@katbyte katbyte modified the milestones: v2.57.0, v2.58.0 Apr 30, 2021
@mbfrahry mbfrahry merged commit 175b86c into master Apr 30, 2021
@mbfrahry mbfrahry deleted the tsi-eventsource-iothub branch April 30, 2021 17:03
mbfrahry added a commit that referenced this pull request Apr 30, 2021
@mbfrahry
Update changelog #11533
01d389f
@ghost
Copy link

ghost commented May 7, 2021

This has been released in version 2.58.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.58.0"
}
# ... other configuration ...

@dariuszdbr dariuszdbr mentioned this pull request May 14, 2021
Open
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/iot-time-series size/XL
Projects
None yet
Milestone
v2.58.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfrahry @katbyte