Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes_cluster: Support for gateway_name for Application Gateway add-on #11984

Merged
merged 2 commits into from
Jun 1, 2021
Merged

kubernetes_cluster: Support for gateway_name for Application Gateway add-on #11984

merged 2 commits into from
Jun 1, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented May 27, 2021 •
edited
Loading

fixes #11357

Acceptance Tests:

--- PASS: TestAccKubernetesCluster_addonProfileIngressApplicationGateway_subnetCIDR (1046.55s)
--- PASS: TestAccKubernetesCluster_addonProfileIngressApplicationGateway_subnetId (1065.66s)

@aristosvo aristosvo mentioned this pull request May 27, 2021
Closed
@aristosvo aristosvo marked this pull request as ready for review May 27, 2021 12:15
favoretti
favoretti approved these changes May 27, 2021
View reviewed changes
Copy link
Collaborator

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo, LGTM! 👍🏻

mbfrahry
mbfrahry requested changes Jun 1, 2021
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aristosvo! This is nearly there! I think it just needs a basic validation check and we'll be there.

azurerm/internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
@aristosvo aristosvo requested a review from mbfrahry June 1, 2021 16:50
@aristosvo aristosvo force-pushed the feature/gateway_name-for-aks-addon-appgw branch from 8224df8 to fbbeb44 Compare June 1, 2021 18:57
mbfrahry
mbfrahry approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry merged commit 02c49a6 into hashicorp:master Jun 1, 2021
mbfrahry added a commit that referenced this pull request Jun 1, 2021
@mbfrahry
Update changelog for #11984
7351dcd
@mbfrahry mbfrahry added this to the v2.62.0 milestone Jun 1, 2021
@ghost
Copy link

ghost commented Jun 4, 2021

This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.62.0"
}
# ... other configuration ...

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@favoretti favoretti favoretti approved these changes

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation service/kubernetes-cluster size/S
Projects
None yet
Milestone
v2.62.0
Development

Successfully merging this pull request may close these issues.

Support AKS Application Gateway Ingress Controller
3 participants
@aristosvo @favoretti @mbfrahry