r/key_vault_certificate: exposing the certificate data field

[thomastaylor312]

Every other key vault resource returns the data

[tombuildsstuff]

hey @thomastaylor312

Thanks for this PR :)

I've taken a look through and this mostly LGTM - if we can fix up the potential crash this should be good to merge :)

Thanks!

[tombuildsstuff]

there's a potential for a crash here, can we make this:

if contents := cert.Cer; contents != nil {
  d.Set("certificate_data", string(*contents))
}

[thomastaylor312]

I was wondering about that. It seemed like a certificate should always be set, but I'll put in a check.

[tombuildsstuff]

that's generally true - however the Azure API's return the state of a resource when it was last modified, rather than as it is right now (as such, it's possible it could be nil)

[thomastaylor312]

Ok, changes made! Thanks for the review @tombuildsstuff

[tombuildsstuff]

hey @thomastaylor312

Thanks for pushing the latest changes - this now LGTM, so I'll kick off the test suite now 👍

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!