Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_environment - support for internal_ip_address, service_ip_address, outbound_ip_addresses #12026

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

bduzik
Copy link
Contributor

@bduzik bduzik commented Jun 1, 2021

#8179

Return the VipInfo for the ASE on create. This is required for configuration of external Azure resources (e.g. App Gateway WAF). Using the data provider will cause failures if the resource doesn't exist. This is the preferred solution.

@ghost ghost added the size/S label Jun 1, 2021
@bduzik bduzik changed the title Retrun VIP information on create. Return VIP information on create. Jun 1, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bduzik - looks good, just need the docs updated with the new properties and this will be good to merge

@ghost ghost added the documentation label Jun 2, 2021
@bduzik
Copy link
Contributor Author

bduzik commented Jun 2, 2021

#12026 @katbyte

Thanks, I've updated the documentation for the resource.

@bduzik bduzik requested a review from katbyte June 2, 2021 13:54
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bduzik - LGTM 👍

@katbyte katbyte changed the title Return VIP information on create. azurerm_app_service_environment - support for internal_ip_address, service_ip_address, outbound_ip_addresses Jun 3, 2021
@katbyte katbyte merged commit c3d39df into hashicorp:master Jun 3, 2021
katbyte added a commit that referenced this pull request Jun 3, 2021
@ghost
Copy link

ghost commented Jun 4, 2021

This has been released in version 2.62.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.62.0"
}
# ... other configuration ...

@github-actions
Copy link

github-actions bot commented Jul 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants