New Data Source: azurerm_kubernetes_cluster
#1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
data-source-kubernetes-cluster
branch
from
93eeca7
to
4b44723
Compare
katbyte
approved these changes
May 7, 2018
| ForceNew: true, | ||
| }, | ||
|
|
||
| "resource_group_name": resourceGroupNameSchema(), |
There was a problem hiding this comment.
Should this be resourceGroupNameForDataSourceSchema()?
| } | ||
|
|
||
| func flattenKubernetesClusterDataSourceAccessProfile(profile *containerservice.ManagedClusterAccessProfile) (*string, []interface{}) { | ||
| if profile != nil { |
There was a problem hiding this comment.
Could be inverted to return return nil, []interface{}{} if nil and to reduce nesting.
| func flattenKubernetesClusterDataSourceAgentPoolProfiles(input *[]containerservice.AgentPoolProfile) []interface{} { | ||
| agentPoolProfiles := make([]interface{}, 0) | ||
|
|
||
| if profiles := input; profiles != nil { |
There was a problem hiding this comment.
check could be inverted to reduce nesting.
|
|
||
| * `name` - (Required) The name of the managed Kubernetes Cluster | ||
|
|
||
| * `resource_group_name` - (Required) The name of the Resource Group in which the managed Kubernetes Cluster exists. |
There was a problem hiding this comment.
Some lines end with a ., some do not
|
Tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Data Source for AKS since they can be useful to reference