[MS] Adding Managed Disk as a Data Source #121
Conversation
There was a problem hiding this comment.
Hey @echuvyrov
Thanks for this PR - besides a couple of minor tweaks this LGTM :)
Tests pass:
$ TF_ACC=1 envchain azurerm go test ./azurerm -v -run TestAccDataSourceAzureRMManagedDisk -timeout 300m -parallel 5
=== RUN TestAccDataSourceAzureRMManagedDisk_basic
--- PASS: TestAccDataSourceAzureRMManagedDisk_basic (197.60s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 197.611s
Thanks!
| * `source_uri` - The source URI for the managed disk | ||
| * `source_resource_id` - ID of an existing managed disk that the current resource was created from. | ||
| * `os_type` - The operating system for managed disk. Valid values are `Linux` or `Windows` | ||
| * `disk_size_gb` - The size of the managed disk in gigabytes. |
There was a problem hiding this comment.
Could we add in the missing tags field too?
website/azurerm.erb
Outdated
|
|
||
| <li<%= sidebar_current("docs-azurerm-datasource-managed-disk") %>> | ||
| <a href="/docs/providers/azurerm/d/managed_disk.html">azurerm_managed_disk</a> | ||
| </li> |
There was a problem hiding this comment.
minor: can we sort this alphabetically in the list?
|
@tombuildsstuff changes made, thanks for review! |
|
Changes LGTM - thanks @echuvyrov :) |
[MS] Adding Managed Disk as a Data Source
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
New data source - managed disks.