Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for share_properties in azurerm_storage_account #12103

Merged
merged 13 commits into from
Jun 17, 2021
Merged

Support for share_properties in azurerm_storage_account #12103

merged 13 commits into from
Jun 17, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jun 8, 2021 •
edited
Loading

Fix #7115
#12104

All tests have passed.

@ghost ghost added size/XL labels Jun 8, 2021
katbyte
katbyte requested changes Jun 16, 2021
View reviewed changes
website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_account.html.markdown
@@ -399,6 +399,29 @@ The following attributes are exported in addition to the arguments listed above:

---

A `share_properties` block supports the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what type of share?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

azurerm_storage_share

website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

Thanks kt. All tests have passed. Please continue reviewing.

@yupwei68 yupwei68 requested a review from katbyte June 16, 2021 06:49
@katbyte katbyte added this to the v2.64.0 milestone Jun 17, 2021
@katbyte katbyte merged commit 372e656 into hashicorp:master Jun 17, 2021
katbyte added a commit that referenced this pull request Jun 17, 2021
@katbyte
CHANGELOG.md for #12103
7ba21d2
@github-actions
Copy link

This functionality has been released in v2.64.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
documentation enhancement service/storage size/XL
Projects
None yet
Milestone
v2.64.0
Development

Successfully merging this pull request may close these issues.

Support for File Share soft delete
2 participants
@yupwei68 @katbyte