Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate arguments before applying them #1405

Closed
antonbabenko opened this issue Jun 18, 2018 · 2 comments
Closed

Validate arguments before applying them #1405

antonbabenko opened this issue Jun 18, 2018 · 2 comments

Comments

@antonbabenko
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Validate obvious arguments before calling SDK. It is probably better to validate on both sides (SDK and Terraform provider).

This is an example of a failure which took 2 minutes:

* azurerm_kubernetes_cluster.test: Long running operation terminated with status 'Failed': Code="InvalidParameter" Message="The Admin Username specified is not allowed."

New or Affected Resource(s)

  • azurerm_kubernetes_cluster

Potential Terraform Configuration

resource "azurerm_kubernetes_cluster" "test" {
  linux_profile {
    admin_username = "user"
    # ...
  }
}
@metacpp
Copy link
Contributor

metacpp commented Jan 26, 2019

@antonbabenko Thanks for opening this issue.

I'd like to share some updates here:

  1. user is acceptable format by admin_username now.
  2. Working on PR to add more validations for K8s fields.

@metacpp metacpp added this to the 2.0.0 milestone Jan 26, 2019
@metacpp metacpp self-assigned this Jan 26, 2019
katbyte pushed a commit that referenced this issue Jan 30, 2019
This PR adds some validation methods for K8s resource fields.

Fixes #1405.
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.22.0 Jan 30, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
@metacpp metacpp assigned metacpp and unassigned metacpp Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants