Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed validation from arm_function_app #1872

Merged
merged 3 commits into from
Sep 5, 2018

Conversation

JimPaine
Copy link
Contributor

@JimPaine JimPaine commented Sep 5, 2018

As mentioned in GH-1731 There are times when you are required to pin the runtime version to a specific version. Also highlighted with this breaking change

Validation has been removed from the version property on arm_function_app and tests updated to validated updating versions still work.

Tests are passing and I have built it and run the provider with a .NET Standard 2 app with using pinned versions and V2.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @JimPaine

Thanks for this PR - if we can remove the entry from the CHANGELOG (which I'll push a commit to fix) this otherwise LGTM 👍

Thanks!

CHANGELOG.md Outdated
@@ -14,6 +14,7 @@ IMPROVEMENTS:
* `azurerm_storage_container` - support for import [GH-1816]
* `azurerm_storage_queue` - support for import [GH-1816]
* `azurerm_storage_table` - support for import [GH-1816]
* `azurerm_function_app` - support for specific versions [GH-1731]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this change? we update the CHANGELOG once things are merged to prevent conflicts (since this file changes frequently)

@tombuildsstuff tombuildsstuff added this to the 1.14.0 milestone Sep 5, 2018
@ghost ghost added the size/S label Sep 5, 2018
@tombuildsstuff
Copy link
Contributor

hey @JimPaine

I hope you don't mind but I've pushed a commit to fix the failing test and now the tests pass / this LGTM 👍 - thanks for this :)

screenshot 2018-09-05 at 18 21 39

Thanks!

@tombuildsstuff tombuildsstuff merged commit 0de848e into hashicorp:master Sep 5, 2018
tombuildsstuff added a commit that referenced this pull request Sep 5, 2018
tombuildsstuff added a commit that referenced this pull request Sep 5, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants