Fix address issue in azurerm_virtual_machine_scale_set when setting the winrm block

[dominik-lekse]

This pull request fixes an issue in azurerm_virtual_machine_scale_set when setting the winrm block in the os_profile_windows_config block. The same address issue has occurred which have been fixed for azurerm_virtual_machine in ddd84ee.

Affected Resource(s)

• azurerm_virtual_machine_scale_set

Acceptance tests

=== RUN   TestAccAzureRMVirtualMachineScaleSet_basicWindows
--- PASS: TestAccAzureRMVirtualMachineScaleSet_basicWindows (518.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	518.432s

References

• Commit ddd84ee fixes this issue for the azurerm_virtual_machine resource
• Fixes issue azurerm_virtual_machine_scale_set os_profile_windows_config winrm settings gets terraform into unworkable state #219 (in combination with pull request Fix panic in azurerm_virtual_machine_scale_set resource with additional_unattend_config block #266)

[tombuildsstuff]

Hey @dominik-lekse

Thanks for this PR - this LGTM - I've tested and from what I can see this doesn't require a Schema migration either :)

Tests pass:

 $ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestAccAzureRMVirtualMachineScaleSet_basicWindows
=== RUN   TestAccAzureRMVirtualMachineScaleSet_basicWindows
--- PASS: TestAccAzureRMVirtualMachineScaleSet_basicWindows (559.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	559.188s

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!