Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host attribute for endpoints of blob, table, queue, and file. #2792

Merged
merged 8 commits into from
Feb 28, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Jan 29, 2019

This PR is to export host attributes for storage account resource, covers primary/secondary endpoints for table, file, queue, and blob.

Fixes #2785

@metacpp metacpp added this to the 2.0.0 milestone Jan 29, 2019
Copy link

@JunyiYi JunyiYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @metacpp for the contributions. I have taken a look throughout the code change and left the comment. It will be good to go if we could fix them.

azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metacpp,

I've left some comments inline

azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
@ghost ghost added size/L and removed size/M labels Jan 31, 2019
@ghost ghost added size/XL and removed size/L labels Jan 31, 2019
@metacpp
Copy link
Contributor Author

metacpp commented Jan 31, 2019

@katbyte @JunyiYi Just updated the PR to address all the issues in the PR.

Copy link

@JunyiYi JunyiYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, there are some additional comments left, please take a look.

azurerm/resource_arm_storage_account.go Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Show resolved Hide resolved
@metacpp
Copy link
Contributor Author

metacpp commented Feb 1, 2019

Thanks for the quick update, there are some additional comments left, please take a look.

@JunyiYi I've address your comments in the PR.

katbyte
katbyte previously requested changes Feb 1, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metacpp,

Thanks for the PR, I've left some comments that need to be addressed before mege. AS well as i do question to reasoning behind pulling out the d.sets into a separate function here. I don't think much is gained by it.

azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_account.go Outdated Show resolved Hide resolved
website/docs/d/storage_account.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: 2.0.0, 1.23.0 Feb 7, 2019
@JunyiYi JunyiYi dismissed their stale review February 11, 2019 08:58

Comments have been resolved.

@metacpp
Copy link
Contributor Author

metacpp commented Feb 19, 2019

@katbyte Thanks for providing these useful comments, I've updated the PR.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacpp LGTM

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review February 28, 2019 08:56

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff merged commit 2291080 into master Feb 28, 2019
@tombuildsstuff tombuildsstuff deleted the enhance/storage branch February 28, 2019 09:03
tombuildsstuff added a commit that referenced this pull request Feb 28, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants