Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a default value to upload_file_size_limit #3012

Conversation

uritau
Copy link

@uritau uritau commented Mar 6, 2019

This PR Solves the issue 3011.
It adds a default value (100) to the application gateway.file_upload_limit_mb.

@tombuildsstuff
Copy link
Contributor

Tests Pass:

screenshot 2019-03-07 at 18 36 15

@tombuildsstuff tombuildsstuff added this to the 1.23.0 milestone Mar 7, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @uritau

Thanks for this PR - this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit 3542a8e into hashicorp:master Mar 8, 2019
tombuildsstuff added a commit that referenced this pull request Mar 8, 2019
@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants