Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure batch expose keys and account url #3071

Merged

Conversation

Lucretius
Copy link
Contributor

This PR exposes the primary access key, secondary access key and account endpoint in the azurerm_batch_account resource and data_source. The documentation has also been updated, with a note that the keys are only available when the batch accounts pool_allocation_mode is BatchService. If the allocation mode is UserSubscription, terraform will throw an error.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hin @Lucretius,

Thanks for the PR, aside from two minor comments iv'e left inline this LGTM 👍

I hope you don't mind but i am going to push a commit to fix them to get this merged 🙂

keys, err := client.GetKeys(ctx, resourceGroup, name)

if err != nil {
return err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wrap this error?

Suggested change
return err
return fmt.Errorf("Error getting kets for Batch Account %q (Resource Group %q): %+v", name, resourceGroup, err)

keys, err := client.GetKeys(ctx, resourceGroupName, name)

if err != nil {
return err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we wrap this error?

Suggested change
return err
return fmt.Errorf("Error getting kets for Batch Account %q (Resource Group %q): %+v", name, resourceGroup, err)

@katbyte katbyte self-assigned this Mar 19, 2019
@katbyte katbyte merged commit 54a2fe7 into hashicorp:master Mar 19, 2019
@katbyte katbyte added this to the v1.24.0 milestone Mar 19, 2019
katbyte added a commit that referenced this pull request Mar 19, 2019
@Lucretius Lucretius deleted the azure-batch-expose-keys-and-account-url branch March 19, 2019 06:16
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 18, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants