Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app service logging with app settings #4243

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Sep 4, 2019

- Update the log settings after updating the app settings and whenever
the app settings change if there's a `logs` block. Azure adds app settings
for the logging configuration, so changing the app settings would otherwise
overwrite them
- Update test case for above
@ghost ghost added the size/M label Sep 4, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phekmat

Thanks for this PR - taking a look through this LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-05 at 14 35 55

@tombuildsstuff tombuildsstuff merged commit 1c869d1 into hashicorp:master Sep 5, 2019
tombuildsstuff added a commit that referenced this pull request Sep 5, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't configure both logging and app settings in azurerm_app_service
2 participants