Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage_account: Ignore Advanced Threat Protection read errors in Azure Germany #4564

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

sigv
Copy link
Contributor

@sigv sigv commented Oct 8, 2019

The Azure Germany Cloud returns HTTP/2.0 404 Not Found when requesting the ATP details. In particular,

Code="InvalidResourceNamespace"
Message="The resource namespace 'Microsoft.Security' is invalid."

As we are simply ignoring the error on Azure Government based on #3920, we can apply the same logic for Azure Germany.

Closes #4563.

The Azure Germany Cloud returns `HTTP/2.0 404 Not Found` when
requesting the ATP details. In particular,

```
Code="InvalidResourceNamespace"
Message="The resource namespace 'Microsoft.Security' is invalid."
```

As we are simply ignoring the error on Azure Government based
on hashicorp#3920, we can apply the same logic for Azure Germany.

Closes hashicorp#4563.
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @sigv, LGTM 💯

@katbyte katbyte added this to the v1.36.0 milestone Oct 9, 2019
@katbyte katbyte changed the title storage_account: Ignore ATP read in Azure Germany storage_account: Ignore Advanced Threat Protection read errors in Azure Germany Oct 9, 2019
@katbyte katbyte merged commit dd69a70 into hashicorp:master Oct 9, 2019
katbyte added a commit that referenced this pull request Oct 9, 2019
@sigv sigv deleted the storage_account-atp_germany branch October 9, 2019 17:27
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@sigv sigv restored the storage_account-atp_germany branch October 29, 2019 12:36
@sigv sigv deleted the storage_account-atp_germany branch October 29, 2019 12:44
sigv added a commit to sigv/terraform-provider-azurerm that referenced this pull request Oct 29, 2019
Although the error message returned from Azure Germany Cloud is
precisely "The resource namespace 'Microsoft.Security' is invalid."
the error message we are seeing in `r/storage_account` has other
contents added on it, so we cannot do an equals check directly.
The ATP fix was being pushed as v1.36.0, but this change provides
the actual resolution.

Ref hashicorp#4563, hashicorp#4564.
@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage_account - ATP not available in Azure Germany
2 participants