Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgres_database allow -s in database collation #4866

Merged
merged 4 commits into from
Nov 18, 2019
Merged

azurerm_postgres_database allow -s in database collation #4866

merged 4 commits into from
Nov 18, 2019

Conversation

wasfree
Copy link
Contributor

@wasfree wasfree commented Nov 13, 2019

According to feedback from Azure Support we should use hyphens instead of underscore if we create databases in azure postgresql. This PR adress issue #4447

Changes:

  • add - to database collation validation
  • adjust validation test
  • emove hyphen underscore rewrite

Fixes #4447

@ghost ghost added the size/XS label Nov 13, 2019
@wasfree wasfree closed this Nov 13, 2019
@wasfree wasfree reopened this Nov 13, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NickMetz,

Thank you for this fix, in addition to the minor comment i've left inline could you add an acceptance test with a - in it to verify that it'll work with the api? thanks!

azurerm/helpers/validate/database.go Outdated Show resolved Hide resolved
@katbyte katbyte changed the title Extend Azure Postgres Database validation azurerm_postgres_database allow -s in database collation Nov 17, 2019
@wasfree
Copy link
Contributor Author

wasfree commented Nov 18, 2019

Hi @NickMetz,

Thank you for this fix, in addition to the minor comment i've left inline could you add an acceptance test with a - in it to verify that it'll work with the api? thanks!

Hi @katbyte,
there was already an test with hyphen in database collation, but it was expected to cause an error. This behavior was changed. However it makes sense to have an test with failure, that for i have added an test "en@US" which is expected to fail.

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-11-18 at 11 37 17

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @NickMetz

Thanks for pushing those changes - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff merged commit f46cc42 into hashicorp:master Nov 18, 2019
tombuildsstuff added a commit that referenced this pull request Nov 18, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_postgresql_database.testdb: Code="InternalServerError" while destroying
3 participants