Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product api not reassigned on manual delete #5054

Merged

Conversation

sschne
Copy link
Contributor

@sschne sschne commented Dec 3, 2019

fixes #5002

Due to behaviour changes in Azure apimanagement API, HTTP 404 response code was not considered an error in version 2018-01-01 and is now considered an error in 2019-01-01. To fix the behavior in the currently used API version, we need to also check for ResponseWasNotFound, when the CheckEntityExists produces no error.

fixes a bug that reflects Azure apimanagement API behaviour changes from 2018-01-01 to 2019-01-01
@ghost ghost added the size/XS label Dec 3, 2019
@tnicolaysen
Copy link
Contributor

I made a PR #5096 for upgrading. Care to have a look? I think it needs review. I've done some basic testing myself, but it would be nice to gain some confidence from someone else testing it.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @pather87

Thanks for this PR - apologies for the delayed review here!

Taking a look through this LGTM - I'll kick off the test suite now 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-12-16 at 08 22 35

@tombuildsstuff tombuildsstuff merged commit 6be581b into hashicorp:master Dec 16, 2019
tombuildsstuff added a commit that referenced this pull request Dec 16, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_product_api does not assign an API to a product if this assignment existed previously
3 participants