Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management - Add http2 protocol support for API Management #5593

Merged
merged 4 commits into from
Feb 10, 2020
Merged

azurerm_api_management - Add http2 protocol support for API Management #5593

merged 4 commits into from
Feb 10, 2020

Conversation

wasfree
Copy link
Contributor

@wasfree wasfree commented Feb 3, 2020

This PR will fix issue #3621 and add support to enable http2 protocol for API Management.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NickMetz. This change looks good with just a minor suggestion to better match the api

website/docs/r/api_management.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @NickMetz

Thanks for pushing those changes - I've taken a look through and left some comments inline but this is looking good to me, if we can fix up the remaining ones (and the tests pass) then this should otherwise be good 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Acceptance tests look fine:

Screenshot 2020-02-10 at 12 18 34

@ghost ghost added size/S and removed size/M labels Feb 10, 2020
@wasfree
Copy link
Contributor Author

wasfree commented Feb 10, 2020

Hi @tombuildsstuff , @mbfrahry,
all required changes has been done and acceptance tests passed.

@ghost ghost removed the waiting-response label Feb 10, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Add http2 protocol support for API Management azurerm_api_management - Add http2 protocol support for API Management Feb 10, 2020
@mbfrahry mbfrahry merged commit 53ac619 into hashicorp:master Feb 10, 2020
mbfrahry added a commit that referenced this pull request Feb 10, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants