Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage: authenticating to the Blob/Queues API's using AzureAD Auth #5614

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This adds support for authenticating to the Blob & Queue Storage API's using AzureAD authentication via a Feature Toggle on the Provider block.

Unfortunately this isn't supported for the Files & Tables API's but is documented to that affect

Fixes #3651

Optional: true,
DefaultFunc: schema.EnvDefaultFunc("ARM_STORAGE_USE_AZUREAD", false),
Description: "Should the AzureRM Provider use AzureAD to access the Storage Data Plane API's?",
},
Copy link
Contributor Author

@tombuildsstuff tombuildsstuff Feb 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is intentionally a top-level feature and not in the features block since it's authentication related (and thus'll change based on the SP being used, rather than the code)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment LGTM 👍

azurerm/internal/services/storage/client/client.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2020-02-05 at 17 33 12

This adds support for authenticating to the Blob & Queue Storage API's
using AzureAD authentication via a Feature Toggle on the Provider block.

Fixes #3651
@tombuildsstuff tombuildsstuff merged commit 579e8ed into master Feb 10, 2020
@tombuildsstuff tombuildsstuff deleted the f/storage-azuread-auth branch February 10, 2020 06:31
tombuildsstuff added a commit that referenced this pull request Feb 10, 2020
@ghost
Copy link

ghost commented Feb 12, 2020

This has been released in version 1.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.44.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider authentication to blob using Azure AD
2 participants