Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_schedule - fix time in future validation #5876

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 25, 2020

fix #5726

terraform will always invoke validation function, we could not make terraform execute validation function only when field changes.

I think the best way for now to solve this problem is to remove the validation.

@ghost ghost added the size/XS label Feb 25, 2020
@@ -82,7 +82,7 @@ func resourceArmAutomationSchedule() *schema.Resource {
Optional: true,
Computed: true,
DiffSuppressFunc: suppress.RFC3339Time,
ValidateFunc: validate.RFC3339DateInFutureBy(time.Duration(5) * time.Minute),
ValidateFunc: validate.RFC3339Time,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing this constraint, could we add the constraint/check into the create/update function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I have added the check into create/update function.

@katbyte katbyte changed the title remove future time validation to avoid second time terraform apply error azurerm_automation_schedule - fix time in future validation Feb 26, 2020
@katbyte katbyte added this to the v2.1.0 milestone Feb 26, 2020
@njuCZ
Copy link
Contributor Author

njuCZ commented Feb 27, 2020

@katbyte Thanks for the suggestion. I have added the check into create/update function

@ghost ghost removed the waiting-response label Feb 27, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ! LGTM now

@katbyte katbyte merged commit c5206db into hashicorp:master Feb 28, 2020
katbyte added a commit that referenced this pull request Feb 28, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants