Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_arm_application_gateway - Fix crash in backend_address_pool.x.fqdns #6549

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Apr 20, 2020

Empty values aren't allowed and cause crashes so we'll prevent that with some extra validation

Fixes #6528

@ghost ghost added the size/XS label Apr 20, 2020
@mbfrahry mbfrahry requested a review from a team April 20, 2020 18:09
@mbfrahry mbfrahry added this to the v2.7.0 milestone Apr 20, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit f8b806b into master Apr 20, 2020
@katbyte katbyte deleted the c-application-gateway-fqdn branch April 20, 2020 23:22
katbyte added a commit that referenced this pull request Apr 20, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_application_gateway: Error: rpc error: code = Unavailable desc = transport is closing
2 participants