Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service ip_restriction - add default for priority #7059

Merged

Conversation

aqche
Copy link
Contributor

@aqche aqche commented May 23, 2020

Fixes: #6876

As noted in the issue, an apply will fail with the Priority must be specified in an all or nothing manner error if multiple ip restrictions are created and some have priority specified while others do not. This PR addresses that error by setting a default priority value of 65000 (this is what Azure defaults to) instead of trying to compute the value.

=== RUN   TestAccAzureRMAppService_completeIpRestriction
=== PAUSE TestAccAzureRMAppService_completeIpRestriction
=== CONT  TestAccAzureRMAppService_completeIpRestriction
--- PASS: TestAccAzureRMAppService_completeIpRestriction (196.92s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests   196.940s

@ghost ghost added the size/XS label May 23, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aqche
This LGTM 👍 - Apologies for missing this behaviour in the review of the previous PR!

@jackofallops jackofallops added this to the v2.13.0 milestone Jun 1, 2020
@jackofallops jackofallops merged commit ba6ba57 into hashicorp:master Jun 1, 2020
jackofallops added a commit that referenced this pull request Jun 1, 2020
@aqche aqche deleted the app_service_ip_restriction_priority branch June 2, 2020 06:52
@ghost
Copy link

ghost commented Jun 4, 2020

This has been released in version 2.13.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.13.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Service IpRestriction - sometimes fails with error about priority setting
3 participants