Support for certificate attributes - azurerm_key_vault_certificate
#7387
Conversation
There was a problem hiding this comment.
hi @njuCZ
I've run the tests for this but they fail due to the assertion being incorrect:
------- Stdout: -------
=== RUN TestAccAzureRMKeyVaultCertificate_basicGenerate
=== PAUSE TestAccAzureRMKeyVaultCertificate_basicGenerate
=== CONT TestAccAzureRMKeyVaultCertificate_basicGenerate
TestAccAzureRMKeyVaultCertificate_basicGenerate: testing.go:640: Step 0 error: Check failed: Check 5/5 error: azurerm_key_vault_certificate.test: Attribute 'certificate_attribute' expected to be set
--- FAIL: TestAccAzureRMKeyVaultCertificate_basicGenerate (274.74s)
FAIL
Would you be able to update the assertion here?
Thanks!
| @@ -112,6 +112,7 @@ func TestAccAzureRMKeyVaultCertificate_basicGenerate(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet(data.ResourceName, "secret_id"), | |||
| resource.TestCheckResourceAttrSet(data.ResourceName, "certificate_data"), | |||
| resource.TestCheckResourceAttrSet(data.ResourceName, "thumbprint"), | |||
| resource.TestCheckResourceAttrSet(data.ResourceName, "certificate_attribute"), | |||
There was a problem hiding this comment.
since this is a nested block this needs to check fields within it:
| resource.TestCheckResourceAttrSet(data.ResourceName, "certificate_attribute"), | |
| resource.TestCheckResourceAttrSet(data.ResourceName, "certificate_attribute.0. created"), |
|
@tombuildsstuff I have updated the test case, please have a look again. |
|
Tests pass:
|
|
This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.17.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
fix #7343
add export fields:
certificate_attribute