Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new 0.1 version to WAF managed_rule_set to support Microsoft_BotManagerRuleSet creation #7579

Conversation

wlodekj
Copy link
Contributor

@wlodekj wlodekj commented Jul 3, 2020

Hey,

This is my first PR here. I wanted to fix an issue with Microsoft_BotManagerRuleSet version 0.1 not being supported in azurerm_web_application_firewall_policy.managed_rules.managed_rule_set. Currently accepted version numbers are:

var ValidateWebApplicationFirewallPolicyRuleSetVersion = validation.StringInSlice([]string{
	"1.0",
	"2.2.9",
	"3.0",
	"3.1",
}, false)

Screenshot 2020-07-03 at 14 37 49

Screenshot 2020-07-03 at 14 38 05

It looks like a Microsoft thing - they have recently changed version 1.0 to 0.1... Added 0.1 version and updated doc files. Not sure if this validation makes sense here, maybe it's better to provide just a full rule name without type and version and be less strict about it?

Thanks,
Jakub

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @wlodekj

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add 1.0 back in then this otherwise LGTM 👍

Thanks!

@wlodekj
Copy link
Contributor Author

wlodekj commented Jul 6, 2020

Hey @tombuildsstuff,

Reverted back 1.0 and update docs.

Thanks!
Jakub

@ghost ghost removed the waiting-response label Jul 6, 2020
@tombuildsstuff tombuildsstuff added this to the v2.18.0 milestone Jul 6, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @wlodekj

@tombuildsstuff tombuildsstuff merged commit 4b64a4d into hashicorp:master Jul 6, 2020
tombuildsstuff added a commit that referenced this pull request Jul 6, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants