Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating to v44.0.0 of github.com/Azure/azure-sdk-for-go #7616

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

ArcturusZhang
Copy link
Contributor

@ArcturusZhang ArcturusZhang commented Jul 8, 2020

This is required by the customer requirement of BlackRock and another RP onboard of hardware security modules

@ghost ghost added the size/XXL label Jul 8, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one comment LGTM 👍

@@ -311,7 +311,9 @@ func resourceArmBlueprintAssignmentDelete(d *schema.ResourceData, meta interface
name := assignmentID.Name
targetScope := assignmentID.Scope

resp, err := client.Delete(ctx, targetScope, name)
// We use none here to align the previous behaviour of the blueprint resource
// TODO: we could add a features flag for the blueprint to empower terraform when deleting the blueprint to delete all the generated resources as well
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this as it may or may not actually be a good idea according to @jackofallops

Suggested change
// TODO: we could add a features flag for the blueprint to empower terraform when deleting the blueprint to delete all the generated resources as well

@katbyte katbyte added this to the v2.19.0 milestone Jul 10, 2020
@katbyte katbyte merged commit 6654794 into hashicorp:master Jul 10, 2020
katbyte added a commit that referenced this pull request Jul 10, 2020
katbyte pushed a commit that referenced this pull request Jul 10, 2020
The machine learning service has changed the delete from a sync operation to an async operation.

Depends on the SDK v44.0.0 PR #7616
@ArcturusZhang ArcturusZhang deleted the update-sdk-to-v44.0.0 branch July 11, 2020 05:09
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants