Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reprovisioning of VM when we attach and detach data disk. #813

Merged
merged 4 commits into from
Feb 15, 2018

Conversation

VaijanathB
Copy link
Contributor

This is the same pull request as Fixes issue when we need to attach/detach data disks #778 . Creating this as I did not wanted to reapply the 42 commits.

@VaijanathB
Copy link
Contributor Author

This is already reviewed and tested as #778

@VaijanathB
Copy link
Contributor Author

Run the tests with test fix and no new failures. @tombuildsstuff Can you please merge this ?

Copy link

@JunyiYi JunyiYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@VaijanathB
Copy link
Contributor Author

Sapient verified that this Pull Request solves their problem.

@@ -227,7 +227,7 @@ func TestAccAzureRMVirtualMachine_bugAzureRM33(t *testing.T) {
})
}

func TestAccAzureRMVirtualMachine_changeStorageDataDiskCreationOption(t *testing.T) {
func TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test currently fails:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption
--- FAIL: TestAccAzureRMVirtualMachine_attachSecondDataDiskWithAttachOption (706.71s)
    testing.go:459: Step 1 error: Check failed: Check 3/3 error: azurerm_virtual_machine.test: Attribute 'storage_data_disk.0.create_option' expected "Attach", got "Empty"
FAIL

I've pushed a commit to fix this

@tombuildsstuff
Copy link
Contributor

Ignoring an Azure provisioning failure - the tests pass:

screen shot 2018-02-14 at 17 08 29

@tombuildsstuff tombuildsstuff merged commit 95ae38c into master Feb 15, 2018
@tombuildsstuff tombuildsstuff deleted the FixAttachDetachDataDisk2 branch February 15, 2018 15:36
tombuildsstuff added a commit that referenced this pull request Feb 15, 2018
@tombuildsstuff tombuildsstuff added this to the 1.1.2 milestone Feb 15, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants