Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault - add support for enable_rbac_authorization #8670

Merged
merged 2 commits into from
Oct 1, 2020
Merged

azurerm_key_vault - add support for enable_rbac_authorization #8670

merged 2 commits into from
Oct 1, 2020

Conversation

masonyc
Copy link
Contributor

@masonyc masonyc commented Sep 29, 2020

added feature for issue
fixes #8401

@ghost ghost added the size/XS label Sep 29, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masonyc
Thanks for this PR. Looks good so far. Can you please add the new property to the relevant docs and I think this will be good to merge.

@jackofallops jackofallops added this to the v2.30.0 milestone Sep 29, 2020
@jackofallops jackofallops changed the title KeyVault - EnableRBACAuthorization - Issue#8401 azurerm_key_vault - add support for enable_rbac_authorization Sep 29, 2020
@jackofallops
Copy link
Member

Tests passing:
image

@ghost ghost added the documentation label Sep 29, 2020
@masonyc
Copy link
Contributor Author

masonyc commented Sep 29, 2020

Hi @jackofallops ,
I have added the property in the documentation. Please let me know if anything else needs to be changed.

@ghost ghost removed the waiting-response label Sep 29, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masonyc - Looks good to me now 👍

@jackofallops jackofallops merged commit bf10f5e into hashicorp:master Oct 1, 2020
jackofallops added a commit that referenced this pull request Oct 1, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for enabling Key Vault RBAC
2 participants