Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_log_analytics_data_export_rule #8995

Merged
merged 7 commits into from
Oct 24, 2020

Conversation

WodansSon
Copy link
Collaborator

No description provided.

@WodansSon WodansSon added this to the v2.34.0 milestone Oct 23, 2020
@WodansSon WodansSon closed this Oct 23, 2020
@WodansSon WodansSon reopened this Oct 23, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WodansSon - aside from a few comments this LGTM 👍

@@ -1,5 +1,5 @@
---
subcategory: "Desktop Virtualization"
subcategory: "DesktopVirtualization"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be changing this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I got called out by the linter so I changed it to what was in the registration code... I'll switch it back to what it was originally. 😄

website/docs/r/log_analytics_data_export.html.markdown Outdated Show resolved Hide resolved
d.Set("export_rule_id", props.DataExportID)
d.Set("destination_resource_id", flattenArmDataExportDestination(props.Destination))
d.Set("enabled", props.Enable)
if tableNames := props.TableNames; tableNames != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the utility function checks for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just looked... if it's nil it returns an empty slice. 🙂

@WodansSon
Copy link
Collaborator Author

image

@WodansSon WodansSon merged commit 4af91fd into master Oct 24, 2020
WodansSon added a commit that referenced this pull request Oct 24, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@katbyte katbyte deleted the nr_logAnalytics_dataExport branch November 16, 2020 16:22
@ghost
Copy link

ghost commented Nov 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants