Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_spring_cloud_service" - exporting outbound_public_ip_addresses #9261

Merged
merged 8 commits into from
Nov 26, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Nov 11, 2020

this PR serves two purpose:

  1. fix spring_cloud_service #9346
  2. exports "outbound_ip" block

the reason of issue 9346:
image
"outbound_ip" is a new field, and there is always a value for this field no matter spring cloud instance is in a virtual network.
so we could make "network" block computed to solve this issue.

image

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @njuCZ

Thanks for this PR - I've taken a look through and left some comments inline but if we can clear those up then we should be good to go 👍

Thanks!

@njuCZ
Copy link
Contributor Author

njuCZ commented Nov 19, 2020

@tombuildsstuff I have moved the field to a top level field. Could you have a look again and check which way is better to solve the diff issue ?

@ghost ghost removed the waiting-response label Nov 19, 2020
@njuCZ
Copy link
Contributor Author

njuCZ commented Nov 20, 2020

@katbyte Thanks for your suggestions. I have updated this PR and all acctest could pass. Please have a look again when free.

@njuCZ njuCZ requested a review from katbyte November 20, 2020 03:09
@tombuildsstuff tombuildsstuff added this to the v2.38.0 milestone Nov 26, 2020
@ghost ghost added size/M and removed size/S labels Nov 26, 2020
@tombuildsstuff
Copy link
Contributor

@njuCZ hope you don't mind but I've pushed a commit to rebase this and move this field to the top level as discussed above

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ & @tombuildsstuff - This LGTM now 👍

@tombuildsstuff tombuildsstuff dismissed their stale review November 26, 2020 10:58

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Contributor

Acceptance Tests look good 👍

@tombuildsstuff tombuildsstuff changed the title "azurerm_spring_cloud_service" - exports "outbound_ip" block "azurerm_spring_cloud_service" - exporting outbound_public_ip_addresses Nov 26, 2020
@tombuildsstuff tombuildsstuff merged commit 1800517 into hashicorp:master Nov 26, 2020
tombuildsstuff added a commit that referenced this pull request Nov 26, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@njuCZ njuCZ deleted the spring_cloud_support_IP branch December 16, 2020 08:57
@ghost
Copy link

ghost commented Dec 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spring_cloud_service
4 participants