New Data Source: azurerm_compute_resource_sku

[MattMencel]

Adding a data resource for Compute Resource SKUs so we can get access to the availability zone data for a particular SKU.

#3025

I added support for most of the available attributes. I'm not 100% sure of the response data for restrictions so there are still a few things marked //TODO in the code.

EXAMPLE USAGE:

provider "azurerm" {}

data "azurerm_compute_resource_skus" "test" {
  name     = "Standard_DS2_v2"
  location = "centralus"
}

output "name" {
  value = "${data.azurerm_compute_resource_skus.test.name}"
}

output "resource_type" {
  value = "${data.azurerm_compute_resource_skus.test.resource_type}"
}

output "tier" {
  value = "${data.azurerm_compute_resource_skus.test.tier}"
}

output "size" {
  value = "${data.azurerm_compute_resource_skus.test.size}"
}

output "family" {
  value = "${data.azurerm_compute_resource_skus.test.family}"
}

output "location_info" {
  value = "${data.azurerm_compute_resource_skus.test.location_info}"
}

output "zones" {
  value = "${data.azurerm_compute_resource_skus.test.location_info.0.zones}"
}

output "capabilities" {
  value = "${data.azurerm_compute_resource_skus.test.capabilities}"
}

output "costs" {
  value = "${data.azurerm_compute_resource_skus.test.costs}"
}

output "restrictions" {
  value = "${data.azurerm_compute_resource_skus.test.restrictions}"
}

OUTPUT:

data.azurerm_compute_resource_skus.test: Refreshing state...

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

capabilities = [
    {
        name = MaxResourceVolumeMB,
        value = 14336
    },
    {
        name = OSVhdSizeMB,
        value = 1047552
    },
    {
        name = vCPUs,
        value = 2
    },
    {
        name = HyperVGenerations,
        value = V1,V2
    },
    {
        name = MemoryGB,
        value = 7
    },
    {
        name = MaxDataDiskCount,
        value = 8
    },
    {
        name = LowPriorityCapable,
        value = True
    },
    {
        name = PremiumIO,
        value = True
    },
    {
        name = vCPUsAvailable,
        value = 2
    },
    {
        name = ACUs,
        value = 210
    },
    {
        name = vCPUsPerCore,
        value = 1
    },
    {
        name = CombinedTempDiskAndCachedIOPS,
        value = 8000
    },
    {
        name = CombinedTempDiskAndCachedReadBytesPerSecond,
        value = 67108864
    },
    {
        name = CombinedTempDiskAndCachedWriteBytesPerSecond,
        value = 67108864
    },
    {
        name = CachedDiskBytes,
        value = 92341796864
    },
    {
        name = UncachedDiskIOPS,
        value = 6400
    },
    {
        name = UncachedDiskBytesPerSecond,
        value = 100663296
    },
    {
        name = EphemeralOSDiskSupported,
        value = True
    }
]
family = standardDSv2Family
location_info = [
    {
        location = centralus,
        zones = [1 2 3]
    }
]
name = Standard_DS2_v2
resource_type = virtualMachines
restrictions = []
size = DS2_v2
tier = Standard
zones = [
    1,
    2,
    3
]

[katbyte]

thanks for the PR @MattMencel,

Would this be better as azurerm_compute_resource_sku? as you are returning the information for a single SKU, not all skus available as i would expect azurerm_compute_resource_skus would

[MattMencel]

Yeah, that makes sense. I was just following along with the pattern in the API (resourceSkusClient).

I also see I'm failing tests and need to put some additional fixes in.

[MattMencel]

Hi @katbyte,

The resource is renamed to azurerm_compute_resource_sku. I also fixed the failing tests.

At some point, if someone really wanted to retrieve the information for multiple SKUs, it would be possible with some additions to the code. Or I could undo my new changes, and have the data resource accept a list of SKUs which it would then return the data for.

I kind of like it only returning one SKU at a time though.

[katbyte]

Thanks for the revisions @MattMencel,

I think it's best for this resource to only return for a single resource. If in the future we wanted to return all available SKUs or multiple i think that would be best as a separate resource azurerm_compute_resource_skus

[katbyte]

@MattMencel,

Given this a more thorough review, its looking good! Just a couple comments i've left inline that need to be addressed before merged

[MattMencel]

@katbyte I think I've addressed the issues you highlighted. I removed all the TODOs. Still not 100% sure on the code for restriction info, but I think it's ok. There are currently zero compute SKUs in any region that have restrictions so I don't see an easy way to verify those at the moment.

[MattMencel]

Updated my branch to the latest commits and made some corrections. The lint test failed due to an out of memory error.

[katbyte]

Hi @MattMencel,

Thank you for this PR and the changes, but upon internal discussion we have decided that the use case of getting the zones for a region/service is probably better served by a more purpose specific azurerm_zones datasource that allows a user to specify a Resource (Microsoft.Compute/virtualMachines)/ and a region (westus) returning just the zones. It seems that is the only output from this datasource that would be useful in terraform and is required for other resource types as well. Given this, whilst I’d like to thank you for this PR, since we’re looking to take a different direction here I’m going to close this PR - but apologies this sat idle for so long.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!