Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GKE Shared VPC support #1528

Merged
merged 5 commits into from
May 23, 2018
Merged

Conversation

danawillow
Copy link
Contributor

@danawillow danawillow commented May 23, 2018

All this needed was to allow setting the network/subnetwork to a self link.

WIP for now because I want to run the tests in CI. Tests are passing.

@morgante
Copy link

Does the test actually work? I believe that Kubernetes Engine also needs to be granted permission on the host network to work properly.

@danawillow
Copy link
Contributor Author

Right, that's why it's still a WIP (Work In Progress)- I'm running the tests to figure out the minimum I can do for them, but our CI infrastructure requires running against a PR (there might be another way to do it but this is the easiest). Once I'm confident this is ready, I'll remove the WIP.

@danawillow danawillow force-pushed the gke-shared-vpc branch 6 times, most recently from 8587aff to bbba1ca Compare May 23, 2018 22:29
@danawillow danawillow requested a review from rosbo May 23, 2018 23:03
@danawillow danawillow changed the title WIP: Add GKE Shared VPC support Add GKE Shared VPC support May 23, 2018
@danawillow danawillow merged commit 974c3f7 into hashicorp:master May 23, 2018
@danawillow danawillow deleted the gke-shared-vpc branch May 23, 2018 23:47
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
All this needed was to allow setting the network/subnetwork to a self link.

~WIP for now because I want to run the tests in CI.~ Tests are passing.
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants