-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GKE Shared VPC support #1528
Conversation
f06595b
to
ec30503
Compare
Does the test actually work? I believe that Kubernetes Engine also needs to be granted permission on the host network to work properly. |
Right, that's why it's still a WIP (Work In Progress)- I'm running the tests to figure out the minimum I can do for them, but our CI infrastructure requires running against a PR (there might be another way to do it but this is the easiest). Once I'm confident this is ready, I'll remove the WIP. |
8587aff
to
bbba1ca
Compare
bbba1ca
to
2e9b893
Compare
All this needed was to allow setting the network/subnetwork to a self link. ~WIP for now because I want to run the tests in CI.~ Tests are passing.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
All this needed was to allow setting the network/subnetwork to a self link.
WIP for now because I want to run the tests in CI.Tests are passing.