Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for deleting networks #662

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

danawillow
Copy link
Contributor

Our tests have been timing out a lot on network deletion lately. I'm not quite sure why it takes more than 4 minutes to delete a network but let's give it 10 minutes just in case.

Checked by running firewall tests, which are currently failing in CI:

=== RUN   TestAccComputeFirewall_importBasic
=== RUN   TestAccComputeFirewall_basic
=== RUN   TestAccComputeFirewall_update
=== RUN   TestAccComputeFirewall_priority
=== RUN   TestAccComputeFirewall_noSource
=== RUN   TestAccComputeFirewall_denied
=== RUN   TestAccComputeFirewall_egress
--- PASS: TestAccComputeFirewall_noSource (296.32s)
--- PASS: TestAccComputeFirewall_basic (306.30s)
--- PASS: TestAccComputeFirewall_importBasic (316.45s)
--- PASS: TestAccComputeFirewall_egress (295.70s)
--- PASS: TestAccComputeFirewall_denied (295.37s)
--- PASS: TestAccComputeFirewall_priority (305.40s)
--- PASS: TestAccComputeFirewall_update (307.44s)
PASS

@paddycarver
Copy link
Contributor

I'm minorly concerned about the 10 minute wait period, which isn't a great user experience, but... on the other hand, I don't see a better alternative, and this is definitely better than leaving it broken.

@danawillow danawillow merged commit 0668525 into hashicorp:master Nov 3, 2017
@danawillow danawillow deleted the network-timeout branch November 3, 2017 18:08
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants