-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for compute network routing mode #838
Add support for compute network routing mode #838
Conversation
Great work! We have the same use case, vpc w/ on-prem networks, so would love to see this get merged asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Michael for adding this feature! :)
I filed a separate issue (#846) for adding update support for this field.
#847 you mean? 😉 |
Ooopsi. Yes :) |
* Add ability to specify compute network routing mode * Update docs
Signed-off-by: Modular Magician <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
I had a need for this when building a VPC that talks to an on-prem network, and noticed that this provider doesn't have a way to specify the VPC routing mode. The current workaround is to add
gcloud compute networks update my-vpc --project my-project --bgp-routing-mode global
tolocal-exec
after creating the VPC.I did a quick search and found that this was asked for in #629.
Docs:
routingConfig
)Tests:
Side note: It is possible to change the routing mode after creating the VPC, but this resource doesn't have an
UpdateFunc
and I didn't want to go through the work of supporting it in this PR. However, if you'd like me to add it before this gets merged, I can do that.