Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS 2 Support #43

Closed
Levi-Armstrong opened this issue Oct 31, 2018 · 12 comments
Closed

ROS 2 Support #43

Levi-Armstrong opened this issue Oct 31, 2018 · 12 comments

Comments

@Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong
Copy link
Contributor Author

@gavanderhoorn I am interested in supporting both ROS 1 and ROS 2 but not sure what is the best/preferred approach. Is it possible to have single branch support both ROS 1 and ROS 2? Also interested in your thoughts about how best to accomplish this.

@Levi-Armstrong
Copy link
Contributor Author

@gavanderhoorn Related to the question above. Several of the package here don't necessarily require ros and could easily be pure cmake packages. In anticipation for adding ROS 2 support is there any reason not to make them pure cmake packages and include a package.xml that allows for them to be build in a ros workspace?

@Levi-Armstrong
Copy link
Contributor Author

I have found solution for switching ros logging. @gavanderhoorn what is your thoughts on the proposed options?

@Levi-Armstrong
Copy link
Contributor Author

Examples of using boost log

@marip8
Copy link
Contributor

marip8 commented Feb 5, 2019

@Levi-Armstrong have you considered using console_bridge? I'm not sure how it will be supported in the future or how it will interface with logging in ROS2 but I think its at least an existing solution for ROS-style logging in ROS-independent packages

@gavanderhoorn
Copy link

@marip8: I've also suggest console_bridge to @Levi-Armstrong. It's a decent suggestion: it has been packaged for ROS 2 usage apparently (ros2/console_bridge_vendor).

@Levi-Armstrong
Copy link
Contributor Author

Looks like a good solution.

@Levi-Armstrong
Copy link
Contributor Author

@gavanderhoorn I must have missed it when you pointed out this as a solution.

@gavanderhoorn
Copy link

I sent you an email about it on 2019-01-30.

@Levi-Armstrong
Copy link
Contributor Author

@gavanderhoorn I found the email and thank you.

@Levi-Armstrong
Copy link
Contributor Author

Levi-Armstrong commented Feb 13, 2019

@gavanderhoorn So I have finished isolating the tesseract_collision in this branch. Currently the only catkin depends is bullet3_ros but this will eventually go away. I am open to solution on how to best release this to support both ROS1 and ROS2.

@mpowelson
Copy link
Contributor

@Levi-Armstrong Can this now be closed? Tesseract_ros2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants