Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ping retry timeout configurable for DockerClientProviderStrategy #217

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Make ping retry timeout configurable for DockerClientProviderStrategy #217

merged 1 commit into from
Sep 21, 2016

Conversation

kunickiaj
Copy link

Resolves #204 by increasing the timeout for ping retries.

@kunickiaj
Copy link
Author

Added system properties to configure each provider's timeout.. open to suggestions for improvement on the system property names.

@kunickiaj kunickiaj changed the title ping timeout of 1s too low in DockerClientProviderStrategy Make ping retry timeout configurable for DockerClientProviderStrategy Sep 20, 2016
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you.

@rnorth rnorth merged commit acea6a9 into testcontainers:master Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants