Issue 247: Add support for $HOME/.docker/config.json #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in issue 247 ( testcontainers#247), docker-java, up to version 3.0.6, hardcoded the private registry authentication file to use ($HOME/.docker/.dockercfg). I updated docker-java to support both config.json and .dockercfg (docker-java/docker-java#756), which has been released in version 3.0.7. This commit upgrades docker-java's version to 3.0.7
|
@rnorth Please review |
|
Hey @tourea, Looks like the Travis build is red, I restarted it, maybe some flaky test. Meanwhile, did you run the tests locally? |
|
😄 it's nice to get this feature with a one-line change! As @bsideup says, it'll be good to get confirmation of no regressions once the tests have run. Would it be worth adding an automated test for this, in case we somehow break it in the future? BTW I think I also want to get my head around how this change might affect:
|
|
I see Did they change anything in docker-java related to execCmd? |
|
I've restarted the Travis build, as this seems to be passing locally for me (Docker for Mac 1.13.0)... |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #247, docker-java, up to version 3.0.6, hardcoded the private registry authentication file to use ($HOME/.docker/.dockercfg).
I updated docker-java to support both config.json and .dockercfg (docker-java/docker-java#756), which has been released in version 3.0.7.
This commit upgrades docker-java's version to 3.0.7