Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not deprecate GenericContainer(String dockerImageName) #3404

Closed
dturanski opened this issue Oct 26, 2020 · 2 comments
Closed

Do not deprecate GenericContainer(String dockerImageName) #3404

dturanski opened this issue Oct 26, 2020 · 2 comments
Milestone
1.15.0

Comments

@dturanski
Copy link

I don't understand why this would be deprecated. DockerImageName seems to provide more value to the framework than the user. In most cases, it's just an unnecessary step for the user.

https://github.com/testcontainers/testcontainers-java/blob/master/core/src/main/java/org/testcontainers/containers/GenericContainer.java#L240
@bsideup bsideup added this to the next milestone Oct 26, 2020
@bsideup
Copy link
Member

bsideup commented Oct 26, 2020

Hey @dturanski,

It was left deprecated by a mistake and is already fixed in #3102. Sorry for that!

@JavaGalaxy
Copy link

I am using 1.17.1 and it still says deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
3 participants
@dturanski @bsideup @JavaGalaxy