fix(configuration): strip whitespaces when reading .testcontainers.properties #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totallyzen
changed the title
totallyzen
pushed a commit
that referenced
this pull request
Mar 19, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](testcontainers-v4.0.1...testcontainers-v4.1.0) (2024-03-19) ### Features * **reliability:** integrate the ryuk container for better container cleanup ([#314](#314)) ([d019874](d019874)) ### Bug Fixes * changelog after release-please ([#469](#469)) ([dcb4f68](dcb4f68)) * **configuration:** strip whitespaces when reading .testcontainers.properties ([#474](#474)) ([ade144e](ade144e)) * try to fix release-please by setting a bootstrap sha ([#472](#472)) ([ca65a91](ca65a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bearrito
pushed a commit
to bearrito/testcontainers-python
that referenced
this pull request
Mar 30, 2024
…operties (testcontainers#474) ## What does this PR do? Strip whitespaces from key and value after reading `~/.testcontainers.properties`. The way TCD writes this file, the `=` will be surrounded by whitespaces, e.g.: ``` kiview@kay ~ % cat .testcontainers.properties tc.host = tcp://127.0.0.1:59499 testcontainers.reuse.enable = true ``` ## Why is it important? Adds Plug&Play support for Testcontainers Desktop and Testcontainers Cloud. ## How to test this PR Run any kind of tests that involve creating and starting containers, while Testcontainers Desktop is running. Testcontainers Desktop should be used and hence started containers can be seen in the Testcontainers Cloud dashboard.
bearrito
pushed a commit
to bearrito/testcontainers-python
that referenced
this pull request
Mar 30, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](testcontainers/testcontainers-python@testcontainers-v4.0.1...testcontainers-v4.1.0) (2024-03-19) ### Features * **reliability:** integrate the ryuk container for better container cleanup ([testcontainers#314](testcontainers#314)) ([d019874](testcontainers@d019874)) ### Bug Fixes * changelog after release-please ([testcontainers#469](testcontainers#469)) ([dcb4f68](testcontainers@dcb4f68)) * **configuration:** strip whitespaces when reading .testcontainers.properties ([testcontainers#474](testcontainers#474)) ([ade144e](testcontainers@ade144e)) * try to fix release-please by setting a bootstrap sha ([testcontainers#472](testcontainers#472)) ([ca65a91](testcontainers@ca65a91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Strip whitespaces from key and value after reading
~/.testcontainers.properties. The way TCD writes this file, the=will be surrounded by whitespaces, e.g.:Why is it important?
Adds Plug&Play support for Testcontainers Desktop and Testcontainers Cloud.
How to test this PR
Run any kind of tests that involve creating and starting containers, while Testcontainers Desktop is running. Testcontainers Desktop should be used and hence started containers can be seen in the Testcontainers Cloud dashboard.