Use RuboCop::CLI::Command::ExecuteRunner #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserves RuboCop exit status while using RuboCop logic for printing summary, either on stdout or stderr with `--stderr` option.
|
Great PR, @nicksieger! This looks great. As for:
I wish I knew, too! It's been so long I really can't recall, and it seems to work the same locally, elsewise. Thank you! |
|
Landed in 1.0.2 |
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserves RuboCop exit status while using RuboCop logic for printing summary, either on stdout or stderr with
--stdin ... --stderroptions.I ran into this issue while running a command like
cat file.rb | standardrb --no-color --stderr --fix --stdin file.rb. I want the reformatted code on stdout with the warnings and summary on stderr. I don't know if the use ofRubocop::Runnerwas intentional, but using the execute runner works for my case.