Replace SemanticBlocks with custom BlockDelimiters #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will move Standard from attempting to enforce Weirich-style semantic blocks, because there will always be edge-cases we can't cover automatically, given how expressive Ruby is and the fact that certain cases are genuinely ambiguous, such that an automated tool cannot reliably determine the authorial intent of a block.
Instead, the new rule will only enforce that single-line blocks be delimited with `{` and `}`, but otherwise allow users to use whatever multiline format they wish.
jmkoni
approved these changes
Mar 3, 2021
|
Thanks for doing this! And thanks again for the awesome project! 💖 |
|
Thank you! always had to disable because of certain edge cases and appreciate the more minimal form of enforcement now (which I really agree with!). Awesome project!!! |
This was referenced Mar 8, 2021
bricesanchez
added a commit
to stampedai/rubocop-stamped
that referenced
this pull request
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will move Standard from attempting to enforce Weirich-style semantic blocks, because there will always be edge-cases we can't cover automatically, given how expressive Ruby is and the fact that certain cases are genuinely ambiguous, such that an automated tool cannot reliably determine the authorial intent of a block.
Instead, the new rule will only enforce that single-line blocks be delimited with
{and}, but otherwise allow users to use whatever multiline format they wish.Resolves #255
Resolves #246
Resolves #94
Resolves #66