-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toHaveValue): Asserting aria-valuenow #479
Conversation
src/utils.js
Outdated
return element.value | ||
default: { | ||
const accessibleValue = getAccessibleValue(element) | ||
return element.value ?? accessibleValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idanen Which should have precedence, value
or aria-valuenow
? At the moment it looks like the former has precedence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value
should take precedence.
That's how Chrome's accessibility tab behaves
@gnapse @nickmccurdy any chance one of you can help push this forward? |
Co-authored-by: Wayne Van Son <[email protected]>
ee8c49c
to
706a94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment that I think needs to be addressed before merging this.
Head branch was pushed to by a user without write access
@gnapse finally fixed the coverage. Can you please give it another look? |
@all-contributors please add @idanen for code, test |
I've put up a pull request to add @idanen! 🎉 |
@all-contributors please add @waynevanson for code, test |
I've put up a pull request to add @waynevanson! 🎉 |
@all-contributors please add @waynevanson for code, test |
@waynevanson already contributed before to code, test |
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #478
What:
Change
.toHaveValue()
to supportaria-valuenow
Why:
How:
Checklist: