feat: rewrite selection handling #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5caa381:
|
Codecov Report
@@ Coverage Diff @@
## alpha #776 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 1320 1384 +64
Branches 507 544 +37
=========================================
+ Hits 1320 1384 +64
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ph-fritsche
added a commit
that referenced
this pull request
Nov 28, 2021
Rewrite the selection utility and refactor how user (character) input is applied. * rewrite selection handling * update selection when moving focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Rewrite how selection ranges / cursor position is handled.
Why:
Previous implementation did not support selection with backward direction, multiple ranges or ranges spanning over different element or ranges including non-character elements.
It also didn't interact with the
SelectionAPI.How:
Implement selection utilities on top of
Selection.Mimick browser implementation on input elements that have their own UI selection independent from
Selectionand without programmatic interface.I removed multi-range implementation for now as it is not available across all major browsers and neither in Jsdom.
Checklist: