Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log correct docs link for invalid key descriptors #881

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Log correct docs link for invalid key descriptors.

Why:

Closes #876

How:

Pass down the context in which the readNextDescriptor utility is called.
Link to the updated docs.

Checklist:

  • Tests
  • Ready to be merged

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Mar 24, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39bd6f4:

Sandbox Source
userEvent-template Configuration

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #881 (39bd6f4) into beta (0da81d2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              beta      #881   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           84        84           
  Lines         1739      1744    +5     
  Branches       628       633    +5     
=========================================
+ Hits          1739      1744    +5     
Impacted Files Coverage Δ
src/keyboard/parseKeyDef.ts 100.00% <100.00%> (ø)
src/pointer/parseKeyDef.ts 100.00% <100.00%> (ø)
src/utils/keyDef/readNextDescriptor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da81d2...39bd6f4. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 28d6604 into beta Mar 24, 2022
@ph-fritsche ph-fritsche deleted the fix-876 branch March 24, 2022 18:02
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link https://github.com/testing-library/user-event/blob/main/README.md#keyboardtext-options is broken
1 participant