Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact statefulset has a non-headless service as it's serviceName #243

Closed
stevehipwell opened this issue Aug 24, 2021 · 4 comments · Fixed by #247
Closed

Compact statefulset has a non-headless service as it's serviceName #243

stevehipwell opened this issue Aug 24, 2021 · 4 comments · Fixed by #247

Comments

@stevehipwell
Copy link
Contributor

I'm not sure if this is a problem, but the compact statefulset doesn't have the corresponding headless service to the value set in serviceName like the other statefulsets.
@yeya24
Copy link
Contributor

yeya24 commented Sep 2, 2021

It makes sense. Are you willing to open a pr to fix it? Thanks!

@stevehipwell
Copy link
Contributor Author

@yeya24 I'll have a go, I'm not really a jsonnet expert and I was working from the example manifests to create a Thanos Helm chart when I spotted this.

@stevehipwell
Copy link
Contributor Author

@yeya24 does compact need a non-headless service as there should only ever be one pod?

@yeya24
Copy link
Contributor

yeya24 commented Sep 7, 2021

@yeya24 does compact need a non-headless service as there should only ever be one pod?

Good point! Then non-headless service seems ok in this case.

@stevehipwell stevehipwell mentioned this issue Sep 8, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compact: make service headless stevehipwell/kube-thanos
2 participants
@stevehipwell @yeya24