Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatObject with Range optimization is breaking, and not as intended? #146

Open
akevdmeer opened this issue Oct 10, 2024 · 2 comments
Open

Comments

@akevdmeer
Copy link

akevdmeer commented Oct 10, 2024

Since #138, Mimir no longer works for us, as our S3 backend (erroneously) responds to StatObject() with a range, with HTTP 416 Requested Range Not Satisfiable.

When GetRange() immediately calls GetObject(), as it did before this was merged, all is well.

Furthermore I have difficulty making sense of the PR. From the title and conversation I understand that the intent is to do a stat instead of an empty read, but the code introduces an unconditional extra StatObject() (that breaks things for us).

How can this extra StatObject() be an optimization, at least in a case like Mimir when the objects requested basically always exist?

Is it possible to revert this PR?

@akevdmeer
Copy link
Author

PR to revert: #148

@aknuds1
Copy link

aknuds1 commented Oct 14, 2024

This can be closed now, right, as #148 is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants