Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gossip from Dashboards and benchmark tool #1180

Closed
povilasv opened this issue May 28, 2019 · 10 comments · Fixed by #1760
Closed

Remove gossip from Dashboards and benchmark tool #1180

povilasv opened this issue May 28, 2019 · 10 comments · Fixed by #1760

Comments

@povilasv
Copy link
Member

We should remove gossip info from the example Grafana dashboards and the benchmark/cmd/thanosbench/*.

@alexissellier
Copy link
Contributor

I would like to work on this.

@povilasv
Copy link
Member Author

@alexissellier awesome, let me know if you need any help

@yeya24
Copy link
Contributor

yeya24 commented Jul 17, 2019

@alexissellier Are you still working on this? If not, I'd like to take this.

@alexissellier
Copy link
Contributor

Go ahead, I still have not internet yet at home due to relocation so I cannot work on it atm

@yeya24
Copy link
Contributor

yeya24 commented Jul 18, 2019

Hi @povilasv . Currently I am working on this, but I am quite confused about this function https://github.com/improbable-eng/thanos/blob/2dadd9caa73343d043bc43062fa8e6a32bac1d9e/benchmark/cmd/thanosbench/resources.go#L497.

What is this image? Is it thanos-querier? Do I have to change this?

Containers: []v1.Container{{
					Name: "querier",
					//TODO(domgreen): move this to the same repository as Thanos
					Image: "eu.gcr.io/io-crafty-shelter/thanos-querier:latest",
					Args: []string{
						"--host=" + endpoint,
						"--queries=" + queries,
						"--range-offset-start=" + opts.queryRangeOffsetStart.String(),
						"--range-offset-end=" + opts.queryRangeOffsetEnd.String(),
						"--query-time=" + opts.queryTime.String(),
						"--server=true",
					},
				}},

@povilasv
Copy link
Member Author

@domgreen might know more :)

@bwplotka
Copy link
Member

Sorry @yeya24 for delay. This is some leaked image, you don't need to worry about this now.

Let's focus on dashboards only now (:

@yeya24
Copy link
Contributor

yeya24 commented Aug 30, 2019

Sorry for the delay @bwplotka . But I am considering is it necessary to maintain the dashboard in this repo? IMO it is better to use https://github.com/metalmatze/kube-thanos. WDYT @bwplotka , do we need to add a doc about that?

@bwplotka
Copy link
Member

Yes, I think the link or even repo in Thanos-io org would be nice indeed

@yeya24
Copy link
Contributor

yeya24 commented Aug 31, 2019

Yes, I think the link or even repo in Thanos-io org would be nice indeed

Agree. /cc @metalmatze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants