Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query: add tests for endpoints + prefix tests #2582

Closed
GiedriusS opened this issue May 10, 2020 · 8 comments
Closed

query: add tests for endpoints + prefix tests #2582

GiedriusS opened this issue May 10, 2020 · 8 comments

Comments

@GiedriusS
Copy link
Member

Coming from #2514 (comment).

We should add some similar tests to what Prometheus has here: https://github.com/prometheus/prometheus/blob/84b4d079c8714be8e8ad071a35b0391df270364c/web/web_test.go#L92. AFAICT it should be pretty easy to do:

  • Refactor the route registering and starting of the HTTP server into a separate function
  • Call it from a test & check all of the endpoints
  • Add a test on what happens if a prefix has been specified

Should prevent #2581. Making a separate issue for this because this should encompass all of the endpoints that we expose to our users.

@bwplotka
Copy link
Member

👍

Help wanted

@tpaschalis
Copy link

I'll take a stab if there's no objection!

@stale
Copy link

stale bot commented Jun 14, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 14, 2020
@kakkoyun
Copy link
Member

@GiedriusS Does #2714 satisfy all the needs here?

@stale stale bot removed the stale label Jun 15, 2020
@squat
Copy link
Member

squat commented Jun 15, 2020

hm not quite, I think we should still test for combinations for external web prefix + web prefix. We identified last week that these are not yet completely correctly handled

@GiedriusS
Copy link
Member Author

External/route prefix tests are being added in #2800.

@stale
Copy link

stale bot commented Jul 28, 2020

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jul 28, 2020
@GiedriusS
Copy link
Member Author

They have been added, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants